Change in ovirt-scheduler-proxy[master]: Code cleanup

lhornyak at redhat.com lhornyak at redhat.com
Thu Aug 29 12:47:28 UTC 2013


Laszlo Hornyak has submitted this change and it was merged.

Change subject: Code cleanup
......................................................................


Code cleanup

Fixes:
- code structure and idioms to adhere to Python standards
- class constructors and attribute initialization
- exception handling issues (like except:)
- string manipulations
- some explicit for loops were converted to list comprehensions
- pep8 compliance

Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M src/ovirtscheduler/API.py
M src/ovirtscheduler/loader.py
M src/ovirtscheduler/oschedproxyd.py
M src/ovirtscheduler/request_handler.py
M src/ovirtscheduler/request_handler_test.py
M src/ovirtscheduler/runner.py
M src/ovirtscheduler/utils.py
7 files changed, 227 insertions(+), 217 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18446
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90e41fcfa46d7aee67de99c83b19937e24a359d3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-scheduler-proxy
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list