Change in ovirt-engine[master]: core: remove redundant code

emesika at redhat.com emesika at redhat.com
Thu Dec 5 09:31:15 UTC 2013


Eli Mesika has submitted this change and it was merged.

Change subject: core: remove redundant code
......................................................................


core: remove redundant code

getMethod will never return null.
It will either return the method, or will throw an exception.
So, in this case, both the if, and the operation inside it, are
redundant it will always be false so inner code will never be reached.

Change-Id: I878243d9a3e205990d2a029c7443cd6d62feb0d3
Signed-off-by: Oved Ourfali <oourfali at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I878243d9a3e205990d2a029c7443cd6d62feb0d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list