Change in ovirt-engine[master]: core: Fix broken bll unit test

amureini at redhat.com amureini at redhat.com
Mon Feb 25 06:25:42 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix broken bll unit test
......................................................................


core: Fix broken bll unit test

An error was introduced due to usage of AsyncTaskDao.getAll in the CTOR of the
AsyncTaskManager sinleton

The following patch uses mocking to create mocked data source +
mocked db facade to handle the error.

Change-Id: If70f5da87e1238f0a545496d6e9700151275d642
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
2 files changed, 27 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/12385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If70f5da87e1238f0a545496d6e9700151275d642
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list