Change in ovirt-engine[master]: packaging: Updated all utilities to use backup.sh instead of...

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jan 28 07:41:46 UTC 2013


Juan Hernandez has submitted this change and it was merged.

Change subject: packaging: Updated all utilities to use backup.sh instead of pg_dump
......................................................................


packaging: Updated all utilities to use backup.sh instead of pg_dump

* Previously, the setup utilities used pg_dump command to backup the
database. The more appropriate way is to use the backup.sh utility,
that runs the dump of the database in a more correct and way. This
also has the added benifit in that changes in DB mechanisms or parameters
for dumping the data would be handled by the external script, and
changes to the setup code would not be required.

Bug-Url: https://bugzilla.redhat.com/866964
Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc
Signed-off-by: Alex Lourie <alourie at redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-upgrade.py
4 files changed, 35 insertions(+), 54 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>



More information about the Engine-commits mailing list