Change in ovirt-engine[master]: core: After enable concurrent option under host...

[emesika at redhat.com]

Eli Mesika has submitted this change and it was merged.

Change subject: core: After enable concurrent option under host...
......................................................................


core: After enable concurrent option under host...

After enable concurrent option under host power management fencing begin failed

This bug was probably caused by a race:
>From the logs its seems that a NULL proxy host is attempt to be used.

There is a check for a valid proxy in canDoAction but not all the
execution paths checks for proxy
Checking for proxy should be also in execute for
single/dual[sequential,concurrent] and the flag that indicates if the
operation succeeded should be set accordingly

Change-Id: I139a7de9a4bb24a56523073b800b929a31fcdc6a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=977689
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 72 insertions(+), 58 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/17206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I139a7de9a4bb24a56523073b800b929a31fcdc6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server