Change in ovirt-engine[master]: core: minor cleanups in MemoryImageRemover class

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: minor cleanups in MemoryImageRemover class
......................................................................


core: minor cleanups in MemoryImageRemover class

1. Define constant instead of using '6' explicitly in the code
2. Rename shouldRemoveMemorySnapshotVolumes method to
   isMemoryStateRemovable
3. Add log printing when the given memory state representation is not in
   the expected format (doesn't have 6 UUIDs separated by comma)
4. Rename local fields
5. Remove 'vm' and 'cachedPostZero' since they are not used by this
   class (so they are moved to the subclasses)
6. Add a boolean class field which indicates whether to start polling
   the created tasks or not, instead of indicating that by setting a
   parameter of the removeMemoryVolumes method

Change-Id: I14cb0bb13d0d103bbc170abcf0348a6909051f2c
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java
3 files changed, 51 insertions(+), 38 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


-- 
To view, visit http://gerrit.ovirt.org/16828
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14cb0bb13d0d103bbc170abcf0348a6909051f2c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server