Change in ovirt-engine[master]: webadmin: Fix missing sub tab panel

vszocs at redhat.com vszocs at redhat.com
Wed May 22 12:49:08 UTC 2013


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Fix missing sub tab panel
......................................................................


webadmin: Fix missing sub tab panel

In order for sub tab presenters and their parent presenters
to receive proper (consistent) life-cycle callbacks, we must
clear sub tab panel slot in MainContentPresenter when hiding
the sub tab panel from the view.

If we don't do the above, MainContentPresenter's sub tab panel
slot will still be occupied with obsolete sub tab presenter,
which will mess up sub tab presenter life-cycle callbacks,
such as onReveal not called each time when sub tab view is
shown in the view.

Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9
Bug-Url: https://bugzilla.redhat.com/964949
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java
5 files changed, 18 insertions(+), 8 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list