Change in ovirt-engine[master]: core: Compensate to unknown status to avoid rollback to acti...

amureini at redhat.com amureini at redhat.com
Tue May 28 11:11:05 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Compensate to unknown status to avoid rollback to active status.
......................................................................


core: Compensate to unknown status to avoid rollback to active status.

On deactivate storage domain command, the storage domain(s) status is being
saved in the compensation context so in case of failure - it will
be reverted to its original value.

In case of failure when executing DeactiveStorageDomainVDSCommand this failure
will propagate to DeactiveStorageDomainCommand and will cause to the compensation
saved data to be applied - which might override the changed statuses and return the
domain status to be active again.

In this change, the domain status is being saved in the compensation
context in unknown status rather then active, so in case of failure the
status would be reverted to unknown.

Change-Id: I9f8a27cbac711fa87db408a06fe22a7b3e9b2da9
Bug-Url: https://bugzilla.redhat.com/920694
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/14767
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f8a27cbac711fa87db408a06fe22a7b3e9b2da9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list