Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - removal of unneeded for loop

iheim at redhat.com iheim at redhat.com
Wed Nov 13 08:17:14 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: export vm - removal of unneeded for loop
......................................................................


core: export vm - removal of unneeded for loop

All the disks that are part of the export are already being iterated
over, their id's can be added during that loop.
Furthermore, there's no need to include id's that aren't part of the
export (of shareable/snapshot disks).

Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0
Related to Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21109
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list