Change in ovirt-engine[master]: core: remove unneeded setSucceeded

laravot at redhat.com laravot at redhat.com
Wed Dec 3 10:10:54 UTC 2014


Liron Aravot has submitted this change and it was merged.

Change subject: core: remove unneeded setSucceeded
......................................................................


core: remove unneeded setSucceeded

The following code in the started thread is executed after the tasks
were cleared, therefore there's no need to execute setSucceeded,
furthermore, as the class isn't thread safe it's risky to have that call
in terms of future changes.

Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Liron Aravot: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35814
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list