Change in ovirt-engine[master]: core: No param dependency in AsyncTasks' equals

amureini at redhat.com amureini at redhat.com
Sun Jan 12 11:26:04 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: No param dependency in AsyncTasks' equals
......................................................................


core: No param dependency in AsyncTasks' equals

AsyncTasks' equals(Object) and hashCode() rely on
VdcActionParametersBase's equals(Object) and hashCode() (respectively),
which are known to be broken (as the inheriting classes do not override
them).

These methods were removed from VdcActionParametersBase in patch
2d884006f356ca95c6b43a509aa809cc3647552c, which neglected to remove the
dependency from AsyncTasks, breaking the DAO test suite.
This patch remedies that mistake.

Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23181
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3b8ce8f32442732b9a529b2d354803ece1b55f4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list