Change in ovirt-engine[master]: core: [Fix] PCI limit in update VM template NIC

masayag at redhat.com masayag at redhat.com
Mon Jan 13 15:37:50 UTC 2014


Moti Asayag has submitted this change and it was merged.

Change subject: core: [Fix] PCI limit in update VM template NIC
......................................................................


core: [Fix] PCI limit in update VM template NIC

* The UpdateVmTemplateInterfaceCommand didn't account for the updated
NICs while passing the interfaces list to the checkPciAndIdeLimits
procedure, so the limit number of NICs could be exceeded when update
the VmInterfaceType. This change fixes this behaviour.
* And was fixed the parameters in the AddVmTemplateInterfaceCommand.

Change-Id: I985e9adeefb00872542f7473f44fb25d44453f8a
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa at eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
2 files changed, 31 insertions(+), 4 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22515
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I985e9adeefb00872542f7473f44fb25d44453f8a
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list