Change in ovirt-engine[master]: webadmin: Wrong vnics when creating vm from blank template

alkaplan at redhat.com alkaplan at redhat.com
Thu Jul 24 08:45:48 UTC 2014


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: Wrong vnics when creating vm from blank template
......................................................................


webadmin: Wrong vnics when creating vm from blank template

The 'Blank' template belongs to the 'Default' dc/cluster.
If the 'Blank' template has vnics with profiles, when creating a vm in
different cluster than 'Default' the vnic profiles (which don't exist in
the vm's cluster) should be overridden by 'Empty' profile.

This override happens in EditProfileBehavior->initSelectedProfile, but
since it is called before the registration of ProfileInstanceTypeEditor
to SelectedItemChangedEvent of VnicInstanceType the new selection of
'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface.

This patch fixes it by calling syncSelectedItemWithNetworkInterface(..)
also before the registration and not just from the eventRaised(..).

Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Bug-Url: https://bugzilla.redhat.com/1103058
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/30637
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list