Change in ovirt-engine[master]: engine: Simplify code in UpdateVdsGroupCommand

lvernia at redhat.com lvernia at redhat.com
Sun Jun 15 14:20:21 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: engine: Simplify code in UpdateVdsGroupCommand
......................................................................


engine: Simplify code in UpdateVdsGroupCommand

Removed a condition that's blocked by canDoAction() - moving a cluster
from one (non-null) DC to another. The realization that this operation
is blocked also enables to simplify the management network logic, and
to always add it and assign it all roles (if it weren't blocked, then
the current code wouldn't be correct anyway, because other networks
could occupy the roles).

Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
1 file changed, 11 insertions(+), 35 deletions(-)

Approvals:
  Lior Vernia: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27831
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list