Change in ovirt-engine[master]: core: change vm custom properties validation

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Mar 9 16:15:43 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: change vm custom properties validation
......................................................................


core: change vm custom properties validation

Change the validation of custom properties of VM when we run it,
such that it will check also the custom properties that resides
within the parameters of RunVm (which are set in run once mode).

This change will allow us to set the custom properties which
resides in the VM object on RunVmOnceCommand from the parameters
after the can do action phase.

In addition, minor refactoring was made to the validation of boot
sequence on run VM.

Change-Id: I66cec8aa76958831924a48b8a7805cf0d181dcf2
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java
4 files changed, 22 insertions(+), 36 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/25405
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66cec8aa76958831924a48b8a7805cf0d181dcf2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list