Change in mom[master]: CpuTune - use previous value if quota or period is None

alitke at redhat.com alitke at redhat.com
Tue Nov 25 15:10:42 UTC 2014


Adam Litke has submitted this change and it was merged.

Change subject: CpuTune - use previous value if quota or period is None
......................................................................


CpuTune - use previous value if quota or period is None

The policy may not set the value of quota or period if it detected no
change. the controller than isn't performing the call to setVmCpuTune.

The fix will make sure to call setVmCpuTune whenever one of the params
changed and it isn't null.

Bug-Url: https://bugzilla.redhat.com/1143992
Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd
Signed-off-by: Roy Golan <rgolan at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35329
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Doron Fediuck <dfediuck at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
---
M mom/Controllers/CpuTune.py
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Martin Sivák: Looks good to me, but someone else must approve
  Doron Fediuck: Looks good to me, but someone else must approve
  Roy Golan: Verified



-- 
To view, visit http://gerrit.ovirt.org/35329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list