Change in ovirt-engine[master]: core, engine, userportal, webadmin: Block floppy support on ...

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core, engine, userportal, webadmin: Block floppy support on PPC64
......................................................................


core, engine, userportal, webadmin: Block floppy support on PPC64

The ppc64 architecture does not support floppy devices, this change
blocks the use of such devices in VMs that do not support them.

A additional property in the osinfo (devices.floppy.support) was created
to indicate if the guest OS supports floppy devices. The RunVmCommand
was changed to validate if the selected VM can use the attached floppy
image and the frontend was changed to hide floppy-related options if
the VM does not support it.

Change-Id: I8fb783bbafa3c6a18e327e4e02aac3d71b6f110b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067605
Signed-off-by: Vitor de Lima <vdelima at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/conf/osinfo-defaults.properties
16 files changed, 81 insertions(+), 0 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved

Objections:
  oVirt Jenkins CI Server: Fails



-- 
To view, visit https://gerrit.ovirt.org/25043
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fb783bbafa3c6a18e327e4e02aac3d71b6f110b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server