Change in ovirt-engine[master]: core: SyntaxCheckerFacotry MockConfigRule usage

amureini at redhat.com amureini at redhat.com
Mon Dec 7 23:46:15 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: SyntaxCheckerFacotry MockConfigRule usage
......................................................................


core: SyntaxCheckerFacotry MockConfigRule usage

Use MockConfigRule to clean up the test and make it easier to read. As
an added bonus, the MockConfigRule takes care of cleaning up the mocked
configuration once the test is over, a cleanup missing from the original
test.

Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
1 file changed, 6 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list