Change in ovirt-engine[master]: core: Introduce postConstruct for commands
rgolan at redhat.com
rgolan at redhat.com
Wed Feb 11 13:23:30 UTC 2015
Roy Golan has submitted this change and it was merged.
Change subject: core: Introduce postConstruct for commands
......................................................................
core: Introduce postConstruct for commands
Replace the need to call DbFacade or other interaction with the command
dependencies during the constructor.
It is ensured (by CommandFactory) that all the command injected
dependencies are already in place.
so instead of:
public DoThisCommand(P p) {
DbFacade.getInstance().getVmDao...
}
we would:
@Override
protected postConstruct() {
dbFacade.getVmDao...
}
Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roy Golan: Verified
--
To view, visit http://gerrit.ovirt.org/37599
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the Engine-commits
mailing list