Change in ovirt-engine[master]: packaging: dbutils: Drop SPs at end

sbonazzo at redhat.com sbonazzo at redhat.com
Wed Jul 1 11:36:09 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: dbutils: Drop SPs at end
......................................................................


packaging: dbutils: Drop SPs at end

dbutils allow passing db credentials.

They also load stored procedures (SPs) using these credentials.

So e.g. running one of them with 'postgres' will leave the relevant SPs
owned by postgres, and a later attempt to run them with the engine user
will fail saying only postgres can run them.

This change drops the SPs at the end of each utility, so the next run
simply loads them again with whatever user passed.

Change-Id: I62496624e20e6d6084ee69b4f03f19b587d0ab94
Bug-Url: https://bugzilla.redhat.com/1080542
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M packaging/setup/dbutils/fkvalidator.sh
M packaging/setup/dbutils/fkvalidator_sp.sql
A packaging/setup/dbutils/fkvalidator_sp_drop.sql
M packaging/setup/dbutils/taskcleaner.sh
M packaging/setup/dbutils/taskcleaner_sp.sql
D packaging/setup/dbutils/taskcleaner_sp_3_5.sql
A packaging/setup/dbutils/taskcleaner_sp_drop.sql
M packaging/setup/dbutils/unlock_entity.sh
M packaging/setup/dbutils/unlock_entity.sql
A packaging/setup/dbutils/unlock_entity_drop.sql
10 files changed, 58 insertions(+), 105 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified



-- 
To view, visit https://gerrit.ovirt.org/42943
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62496624e20e6d6084ee69b4f03f19b587d0ab94
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list