Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest lists

amureini at redhat.com amureini at redhat.com
Mon Jul 13 20:13:17 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: DeactivateStorageDomainCommandTest lists
......................................................................


core: DeactivateStorageDomainCommandTest lists

Stop using the confusing ArrayList in
DeactivateStorageDomainCommandTest, and instead use
Collections.emptyList() and Collections.singletonList(Object)
to make the test easier to read, and to reduce the possibility of these
lists being modified mistakenly.

Change-Id: I72c60e44e1daed90113e1e477c75133bee7d7f51
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/43522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72c60e44e1daed90113e1e477c75133bee7d7f51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list