Change in ovirt-engine-cli[master]: cli: Support escape of double quote in strings

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon May 18 09:50:10 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Support escape of double quote in strings
......................................................................


cli: Support escape of double quote in strings

Currently strings support escape sequences, but they aren't replaced by
the corresponding characters. For example, in the following command:

  # update vm myvv --name "My \"VM\""

The name of the VM will be set to exactly this:

  My \"VM\"

Note that the backslash isn't removed.

This makes it impossible to use strings that represent data that
contain double quotes, in particular it makes it impossible to use XML
documents, which are needed when setting the OVF representation of a VM.

This patch changes the CLI so that the escape character preceding the
double quote will be removed, thus the above command will result in the
following name:

  My "VM"

Change-Id: Ied53ac577efa3395438892de535c35cd068a12bd
Bug-Url: https://bugzilla.redhat.com/1211670
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M src/cli/parser.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied53ac577efa3395438892de535c35cd068a12bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list