Change in ovirt-engine[master]: core: rm getNonEligibilityReasonsForSlaveVolume1()

amureini at redhat.com amureini at redhat.com
Mon Nov 30 10:18:16 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: rm getNonEligibilityReasonsForSlaveVolume1()
......................................................................


core: rm getNonEligibilityReasonsForSlaveVolume1()

This method just returns an empty ArrayList, and was only used to
assert against. Removing it and asserting that various lists are empty
makes the code much cleaner and easier to understand.

Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQueryTest.java
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Sahina Bose: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48947
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If077e5074c9630f6a8ace24b092902b309ddcc87
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list