Change in ovirt-engine[master]: engine: Stop checking if hosts support live snapshot

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Stop checking if hosts support live snapshot
......................................................................


engine: Stop checking if hosts support live snapshot

Old VDSM versions on EL servers required qemu-kvm, which is a stripped
down upstream flavor of qemu that does not support live snapshots. This
created a situation where even though a host had a sufficiently high
VDSM version to be part of a cluster that theoretically allowed live
snapshots (i.e., 3.1 or above), the host itself may not have supported
this feature, leading to the need to check for it explicitly, regardless
of the cluster version.

Modern VDSM versions (specifically, 4.17 or above, which is the minimal
requirement to connect to the current engine) require qemu-kvm-[rh]ev in
their spec file, promising the ability to perform live snapshots.

This commit removes the liveSnapshotSupported property from VdsDynamic,
VDS, the relevant database objects and any [redundant ]validations
around it.

Note that this property is visible in the REST API, although it's a
read-only property which cannot be updated or manipulated.
As the REST API model currently still specifies this property, the
current patch does not remove it, but instead stubs it with a hardcoded
`true` value. A subsequent patch will require a newer
ovirt-engine-api-model version (which is not yet released at the time
this patch was authored) to remove it from the API too.

Change-Id: I9f1bcbd898885b999a57184eba8bc65c9c993900
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralInfoView.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0520_remove_live_snapshot_support_check.sql
M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M packaging/dbscripts/vds_sp.sql
18 files changed, 4 insertions(+), 100 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f1bcbd898885b999a57184eba8bc65c9c993900
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>