Change in ovirt-engine-sdk-java[sdk_4.0]: Name plular element tag same as the member

omachace at redhat.com omachace at redhat.com
Thu Aug 18 15:06:21 UTC 2016


Ondra Machacek has submitted this change and it was merged.

Change subject: Name plular element tag same as the member
......................................................................


Name plular element tag same as the member

Previously when we send action and contruct XML with
list of the entity we named tags by the entity. This
patch changes the behavior, so we name it by the member
which is written.

For example if we want to create bonds, we will send following xml:

  <action>
    <modified_bonds>
      <host_nic>
        <bonding>
          <options>...</options>
          <slaves>
            <host_nic>
              <name>eth0</name>
            </host_nic>
            <host_nic>
              <name>eth1</name>
            </host_nic>
          </slaves>
        </bonding>
        <name>bond0</name>
      </host_nic>
    </modified_bonds>
  </action>

Previously we sent <host_nics> instead of <modified_bonds>.

Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede
Signed-off-by: Ondra Machacek <omachace at redhat.com>
(cherry picked from commit d02068fa1c10ee25476037d6ed371d5f7ca25e0d)
---
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java
A sdk/src/test/java/org/ovirt/engine/sdk4/SetupNetworksTest.java
3 files changed, 138 insertions(+), 18 deletions(-)

Approvals:
  Ondra Machacek: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62561
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc390782659effbfb1d70421da9e5e9d45129ede
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list