Change in ovirt-engine[master]: core: Fix MaxImagesInChain config value mocks

tnisan at redhat.com tnisan at redhat.com
Mon Aug 29 14:06:38 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Fix MaxImagesInChain config value mocks
......................................................................


core: Fix MaxImagesInChain config value mocks

The mocks were in version 'General' instead of 'general' which caused the
class to ignore it when trying to fetch the value, this was changed to
the correct version and since now the class is fetching the value it's
also necessary to have it as an Integer rather than an empty String to
avoid ClassCastException

Change-Id: I7fad34ac6e9ecddda51d2c00613a5084a6bba14f
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified; Passed CI tests
  Allon Mureinik: Looks good to me, approved
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/62938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fad34ac6e9ecddda51d2c00613a5084a6bba14f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list