Change in ovirt-engine[master]: restapi: Populate V3 snapshot type correctly

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Jun 20 10:23:26 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Populate V3 snapshot type correctly
......................................................................


restapi: Populate V3 snapshot type correctly

In version 3 of the API the VmBase#type attribute had two different
meanings, depending on the context: the type of virtual machine (desktop
of server) when used with virtual machines or templates, and the type of
snapshot (regular, active, etc) when sued with snapshots. In version 4
of the API this isn't possible because each attribute has attribute has
exactly one type. To handle that a new `snapshot_type` attribute was
added to the snapshot entity. But the version 3 compatibility layer
didn't take this into account, and as a result the old `type` attribute
wasn't populated. This patch fixes that, so the old `type` attribute is
populated correctly.

Change-Id: I8b50b994533135fbc0a5d924a3df958b4b6cb584
Bug-Url: https://bugzilla.redhat.com/1348138
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotInAdapter.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotOutAdapter.java
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/59462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b50b994533135fbc0a5d924a3df958b4b6cb584
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list