Change in ovirt-engine-sdk[sdk_3.6]: sdk: Support URL parameters in actions

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Mar 28 10:58:24 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: sdk: Support URL parameters in actions
......................................................................


sdk: Support URL parameters in actions

Currently the SDK doesn't support the URL parameters that are available
in some actions. For example, the action to deactivate a host supports
the "async" parameter, but it isn't possible to use in the SDK because
the signature of the "deactivate" method doesn't contain it:

  def deactivate(
    self,
    action=params.Action(),
    correlation_id=None
  )

It should be like this instead:

  def deactivate(
    self,
    action=params.Action(),
    correlation_id=None,
    async=None
  )

In order to support that this patch modifies the code generator so that
these URL parameters are added to the signature, and sent to the server.

Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3
Bug-Url: https://bugzilla.redhat.com/1311495
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Action.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Documentation.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/ResourceActionTemplate
M src/ovirtsdk/infrastructure/brokers.py
4 files changed, 1,252 insertions(+), 775 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list