Change in ovirt-engine[master]: core: move disks storage existence check to DiskImagesValidator

laravot at redhat.com laravot at redhat.com
Thu May 19 08:18:42 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: move disks storage existence check to DiskImagesValidator
......................................................................


core: move disks storage existence check to DiskImagesValidator

We check in multiple places whether disks exists on the storage domains by
getting the list of the images on the storage domain.
This patch moves the check to DiskImagesValidator and removes the duplicacy
between ExportVmTemplateCommand and ImportValidator.

Change-Id: I1427b3531dafc6dcb64001c4755b4e7276007682
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java
3 files changed, 49 insertions(+), 60 deletions(-)

Approvals:
  Liron Aravot: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1427b3531dafc6dcb64001c4755b4e7276007682
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list