Change in ovirt-engine[master]: engine: ovirt-node should wait for restart after upgrade

Code Review gerrit at ovirt.org
Wed Nov 30 15:53:18 UTC 2016


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: ovirt-node should wait for restart after upgrade
......................................................................


engine: ovirt-node should wait for restart after upgrade

The SSH host reboot command changed as follow:
1. Set the host to 'Reboot' status: status is set to reboot once the reboot
   command was successfully invoked on the host.
2. Added a sleep: Instead of setting the host's status immediately to its
   previous status, there should be a delay to allow the host to start the
   reboot and to prevent from the host monitoring to grab the host and attempt
   to move it to up.
3. Fixed a bug in which the initial host status was ignored.
4. Set the default status after reboot is 'non-responsive'. This align
   the behavior of the command with the host installation flow.
5. Support upgrading host or checking for hosts upgrade in Maintenance
   mode.

In addition, the ovirt-node upgrade process will be reported as a
failed one if the expected reboot step didn't start properly.

Change-Id: If2e3b4fcafb98fa6e14da54c1c42f9d20e4d1278
Bug-Url: https://bugzilla.redhat.com/1382691
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
3 files changed, 22 insertions(+), 13 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Moti Asayag: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/67554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2e3b4fcafb98fa6e14da54c1c42f9d20e4d1278
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list