Change in ovirt-engine[master]: webadmin: FormatterJava case scopes

tnisan at redhat.com tnisan at redhat.com
Tue Oct 18 16:33:50 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: FormatterJava case scopes
......................................................................


webadmin: FormatterJava case scopes

Removed the anonymous blocks in the switch-case statement as per the
project's checkstyle requirement.
Note that in order to achieve this the variables i, flags and sep were
extracted outside of the switch block. In the one place where i was
defined as a long the expression was inlined to avoid a compilation
error.

Change-Id: Ie8e1e0dd92531158759ebc9f62e5f8d45aba06af
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/FormatterJava.java
1 file changed, 37 insertions(+), 49 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65494
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e1e0dd92531158759ebc9f62e5f8d45aba06af
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list