Change in ovirt-engine[master]: core: AffinityGroupCRUDCommand#init

tnisan at redhat.com tnisan at redhat.com
Thu Oct 20 12:37:59 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: AffinityGroupCRUDCommand#init
......................................................................


core: AffinityGroupCRUDCommand#init

Move the initialization logic from the command's constructor to the
init() method, as per the project's standard.

This is done in order to move any DAO calls to the postConstruct phase,
where it's safe to use them, and better facilitate testing these
commands.

Change-Id: I7ca5b59817d7b93924814a5c1e848e7afa19e580
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Roman Mohr: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/64780
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7ca5b59817d7b93924814a5c1e848e7afa19e580
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list