Change in ovirt-engine[master]: core: QuotaDaoTest: Remove Config dependency

amureini at redhat.com amureini at redhat.com
Thu Oct 27 22:46:10 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: core: QuotaDaoTest: Remove Config dependency
......................................................................


core: QuotaDaoTest: Remove Config dependency

The QuotaDaoTest tests performing database CRUD operations on Quota
objects. The actual values set on the Quota object are
inconsequential for this test, and there's no reason to query them from
Config values in the database.

This patch removes the quota dependency and replaces the Config calls
with the actual values that would have been returned from the test
database.

Change-Id: If5a13d9675f0b49d663fa6a1e46e75c49c5b3bb9
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDaoTest.java
1 file changed, 12 insertions(+), 14 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5a13d9675f0b49d663fa6a1e46e75c49c5b3bb9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list