Change in ovirt-engine[master]: engine: Use nop-logger for tests

amureini at redhat.com amureini at redhat.com
Thu Sep 15 18:56:26 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: Use nop-logger for tests
......................................................................


engine: Use nop-logger for tests

Printing out the logging information during unit tests isn't very
interesting on the one hand, and on the other it slows down the build
dramatically.

Changing the slf4j implementation from the jdk logger
to the nop logger improved build time by more than 10% on my machine
(from ~7:20 minutes to ~6:10 minutes).

Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
D backend/manager/modules/bll/src/test/resources/logging.properties
D backend/manager/modules/dal/src/test/resources/logging.properties
D backend/manager/tools/src/test/resources/logging.properties
M pom.xml
4 files changed, 1 insertion(+), 61 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Allon Mureinik: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list