Change in ovirt-hosted-engine-setup[master]: network: validating hostname syntax also on the first host

stirabos at redhat.com stirabos at redhat.com
Tue Sep 27 16:08:04 UTC 2016


Simone Tiraboschi has submitted this change and it was merged.

Change subject: network: validating hostname syntax also on the first host
......................................................................


network: validating hostname syntax also on the first host

On the first host we acquire the hostname from the
interface we are going to use to create the management
bridge. We still need to validate it to prevent further
errors when we'll try to add the host into the engine.

Change-Id: Ia879150d59b325d8c8fe25dfc29aa89aac0132cb
Bug-Url: https://bugzilla.redhat.com/1366270
Depends-On: https://gerrit.ovirt.org/64475
Signed-off-by: Simone Tiraboschi <stirabos at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/network/bridge.py
2 files changed, 27 insertions(+), 0 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64472
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia879150d59b325d8c8fe25dfc29aa89aac0132cb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list