Change in ovirt-engine[master]: core: StorageServerConnectionDaoTest#existingNfsAutoConnection
Code Review
gerrit at ovirt.org
Tue Aug 8 17:10:50 UTC 2017
>From Allon Mureinik <amureini at redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80313 )
Change subject: core: StorageServerConnectionDaoTest#existingNfsAutoConnection
......................................................................
core: StorageServerConnectionDaoTest#existingNfsAutoConnection
The only usage for this member is its ID, which can be taken from
FixturesTool anyway.
This patch removes this redundant member, both in order to clean up
the code and to speed up the test by removing a useless DAO call from
the test's setup.
Change-Id: Iaa95d1ec41d9cf55bbbfeb367b6e76a4d5d52dc1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/80313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa95d1ec41d9cf55bbbfeb367b6e76a4d5d52dc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list