Change in ovirt-engine[master]: core: Avoid redundant load of disk snapshots in RemoveImageC...

Code Review gerrit at ovirt.org
Mon Aug 28 12:49:53 UTC 2017


>From Tal Nisan <tnisan at redhat.com>:

Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80918 )

Change subject: core: Avoid redundant load of disk snapshots in RemoveImageCommand
......................................................................


core: Avoid redundant load of disk snapshots in RemoveImageCommand

The recourse getImageChildren fetches all the disk snapshots from the
DB and returns the list of their IDs just to have the snapshots fetched
again from the DB in order to remove them, this is redundant and was
replaced by returning the actual disk snapshot

Change-Id: Id29b928939e7da307cbfe3d393d85f14c44dcffa
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/80918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id29b928939e7da307cbfe3d393d85f14c44dcffa
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eyal Shenitzky <eshenitz at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list