Change in ovirt-engine[master]: frontend: BreadCrumbsView: don't encode strings twice.

Code Review gerrit at ovirt.org
Wed Aug 30 17:51:50 UTC 2017


>From Alexander Wels <awels at redhat.com>:

Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/81229 )

Change subject: frontend: BreadCrumbsView: don't encode strings twice.
......................................................................


frontend: BreadCrumbsView: don't encode strings twice.

setText encodes strings to safe html, while currentName
itself is guaranteed to already be encoded. This causes
the entry to be encoded twice and not be displayed
properly (displaying html entities instead).

Directly set the strings via setInnerHTML instead. As
currentName is guaranteed to be encoded, it is safe.

Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1483295
Change-Id: I145c2428442c42a5a3e563968c45eb8265852a57
Signed-off-by: Leon Goldberg <lgoldber at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/OvirtBreadCrumbsView.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Leon Goldberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/81229
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I145c2428442c42a5a3e563968c45eb8265852a57
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list