Change in ovirt-engine[master]: core: remove another redundant legacy check in create vm

Code Review gerrit at ovirt.org
Tue Feb 7 13:45:43 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: remove another redundant legacy check in create vm
......................................................................


core: remove another redundant legacy check in create vm

In RunVm we validate that the VM is not during snapshot (that is, that
no snapshot is locked) while the VM is locked and then we check it
again in the create VDS command. The latter check is redundant since
every time that we lock a snapshot (and specifically the active
snapshot) we do it while the VM is locked.

In addition, removing unused method in SnapshotsManager.

Change-Id: I05d8a28e462ff942370fa21477f4524c246daff2
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
2 files changed, 0 insertions(+), 44 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/71702
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I05d8a28e462ff942370fa21477f4524c246daff2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list