Change in ovirt-engine[master]: core: move initialization type from vm to the parameters of ...

Code Review gerrit at ovirt.org
Tue Feb 21 14:14:54 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged.

Change subject: core: move initialization type from vm to the parameters of run-vm
......................................................................


core: move initialization type from vm to the parameters of run-vm

It is not really a property of a VM but a configuration for the run operation
(for example, in the next run we may want to use cloud-init and on the next
run we certainly won't want it because the VM is already initialized). Thus,
this patch moves the initilizationType from the overloaded VM object to the
parameters of Create command.

Change-Id: I8e11c3db2ce9fa8501c6f4e8bbe319f47a6be0b9
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java
4 files changed, 18 insertions(+), 17 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/72686
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e11c3db2ce9fa8501c6f4e8bbe319f47a6be0b9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list