Change in ovirt-engine[master]: core: create Pool with 'auto select target' on disks with id...

Code Review gerrit at ovirt.org
Wed Jul 12 14:33:31 UTC 2017


>From Arik Hadas <ahadas at redhat.com>:

Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79301 )

Change subject: core: create Pool with 'auto select target' on disks with identical DD
......................................................................


core: create Pool with 'auto select target' on disks with identical DD

Trying to create new Pool based on a Template with at least two disks
from the same Data Domain (same Target) and checking the 'Auto select
target' check box (in 'Resource Allocation' side tab), causes the whole
pool creation to fail.

This bug is because of invalid use of Java Streams in ImagesHandler
(done as part of a refactoring patch: commit a6d29adf20b9052b117e86c36a01dcc0fce7c9e7).
This patch fixes it by replacing the Java Streams back to a regular loop
statement.

Change-Id: I702b65a5411ec1bb92a8c40829cbd271d7c9b29f
Bug-Url: https://bugzilla.redhat.com/1468313
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/79301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I702b65a5411ec1bb92a8c40829cbd271d7c9b29f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list