Change in ovirt-engine[master]: React on communication failure on external network import

Code Review gerrit at ovirt.org
Thu Jun 8 08:34:40 UTC 2017


>From Alona Kaplan <alkaplan at redhat.com>:

Alona Kaplan has submitted this change and it was merged.

Change subject: React on communication failure on external network import
......................................................................


React on communication failure on external network import

During the import of an external network, the networks on
an external network provider are queried.
If the query fails, the user is informed by an ErrorPopup.

Change-Id: I61f862ce521b9bcaae564a96b2da276215e556a8
Bug-Url: https://bugzilla.redhat.com/1451232
Signed-off-by: Dominik Holler <dholler at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
4 files changed, 63 insertions(+), 35 deletions(-)

Approvals:
  Dominik Holler: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/77747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61f862ce521b9bcaae564a96b2da276215e556a8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list