Change in ovirt-engine[ovirt-engine-4.1]: backend: generic type of PostDeleteActionHandler::fixParameters
Code Review
gerrit at ovirt.org
Wed Mar 1 16:35:47 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: generic type of PostDeleteActionHandler::fixParameters
......................................................................
backend: generic type of PostDeleteActionHandler::fixParameters
PostDeleteActionHandler::fixParameters gets a parameters object of type
<T extends StorageDomainIdParametersBase & PostDeleteAction>.
While this is a correct generic type, it can be more specific since all
the parameters that are sent to this handler extend
StoragePoolDomainAndGroupIdBaseVDSCommandParameters, which is a subtype
of StorageDomainIdParametersBase.
Change-Id: Iff6988365db5e237dc736f333711047762dc4967
Bug-Url: https://bugzilla.redhat.com/1427543
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java
2 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73347
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff6988365db5e237dc736f333711047762dc4967
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list