Change in ovirt-engine-sdk-ruby[master]: Send INFO log messages with summaries of requests and responses

Code Review gerrit at ovirt.org
Thu Mar 2 18:47:43 UTC 2017


>From Juan Hernandez <juan.hernandez at redhat.com>:

Juan Hernandez has submitted this change and it was merged.

Change subject: Send INFO log messages with summaries of requests and responses
......................................................................


Send INFO log messages with summaries of requests and responses

Currently the SDK only sends output the log when the 'debug' parameter
is 'true', and then it sends all the HTTP traffic. This is too much
information in most production environments, so an intermediate level of
information is required. This patch changes the SDK so that it will use
the 'INFO' level so send summaries of the requests sent and the
responses received, something like this:

  INFO: Sending 'GET' request to URL 'https://myserver/ovirt-engine/api/vms?search=name%3Dmyvm'.
  INFO: Received response code '200'.

This will be automatically enabled when passing a 'log' parameter to the
constructor of the 'Connection' class.

Change-Id: I38a81b8e646b8a327ccc3d80738e9d95c4055fc1
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/73134
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38a81b8e646b8a327ccc3d80738e9d95c4055fc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list