Change in ovirt-engine[master]: engine: Use conventional AuditLogDirector log method

Code Review gerrit at ovirt.org
Wed May 3 07:29:06 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Use conventional AuditLogDirector log method
......................................................................


engine: Use conventional AuditLogDirector log method

The AuditLogDirector.log() which expects unformat message is too complex
and its usage is less clear, especially when it can be totally avoided.
NetworkConfigurator error handling is updated to avoid it.

Change-Id: Id03c91d2837178480653756bfa030dbae042110f
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 6 insertions(+), 18 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76199
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id03c91d2837178480653756bfa030dbae042110f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list