Change in ovirt-engine[master]: engine: Extract message resolving logic from AuditLogDirector

Code Review gerrit at ovirt.org
Sun May 7 15:58:54 UTC 2017


>From Moti Asayag <masayag at redhat.com>:

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Extract message resolving logic from AuditLogDirector
......................................................................


engine: Extract message resolving logic from AuditLogDirector

The message resolving can be extracted into its own class, to be
consumed either by the AuditLogDirector or by other clients which
requires that functionality. There is no good reason to require the
entire AuditLogDirector only for that functionality, and since it is a
specific responsibility, it can be stored on its own class.

This patch perfoms a simple refactor and extracts the methods as static
to the new class. Later-on, we can change the nature of this class to be
injected where needed.

Change-Id: I77f6e268e444ae9941d40f8e07e15bd00b98dd8a
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/MessageResolver.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirector.java
R backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/MessageResolverTest.java
4 files changed, 117 insertions(+), 106 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved
  Moti Asayag: Verified



-- 
To view, visit https://gerrit.ovirt.org/76484
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77f6e268e444ae9941d40f8e07e15bd00b98dd8a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list