Change in ovirt-engine[master]: core: ReduceSD - fail when no md devices info

Code Review gerrit at ovirt.org
Thu May 18 06:31:18 UTC 2017


>From Liron Aravot <laravot at redhat.com>:

Liron Aravot has submitted this change and it was merged.

Change subject: core: ReduceSD - fail when no md devices info
......................................................................


core: ReduceSD - fail when no md devices info

In some user envs the metadata for a block sd was resotored in a way
preventing vdsm to determine the vg metadata device of the domain.
As we don't support that configuration - we'd like to prevent devices
from being reduced from the domain in that case. This patch changes the
reduce command to verify that the metadata devices are present before
allowing to reduce a device from the domain.

Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Liron Aravot: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/76607
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the Engine-commits mailing list