Change in ovirt-engine[master]: packaging: setup: Check health

[Code Review]

>From Sandro Bonazzola <sbonazzo at redhat.com>:

Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: setup: Check health
......................................................................


packaging: setup: Check health

This patch introduces a new utility that can create a standalone script
that can be copied to an older engine machine and ran to get a report.

Currently this report does not do much, but it's expected that we'll
move most of the checks done during engine-setup to be ran also by this
script.

Details:

packaging/setup/bin/bundle-ovirt-engine-health

- creates this "bundle" standalone script

packaging/setup/bin/ovirt-engine-health

- The health checker itself. Can also be ran directly on the engine
  machine, but is mainly intended to be wrapped in the bundle.

packaging/setup/plugins/ovirt-engine-checks:

- A new plugins directory, that is shared by both engine-setup and
ovirt-engine-health.

packaging/setup/plugins/ovirt-engine-health:

- A new plugins directory, specific to the health checker

Also patched the spec and make files to allow building.

Also added packaging/setup/plugins/README to document this directory a
bit.

Also copied the code that checks cluster/DC versions compatibility to a
new plugin in plugins/ovirt-engine-checks, as a POC.

To try this, on the engine machine, after setup, run:

sh /usr/share/ovirt-engine/setup/bin/bundle-ovirt-engine-health

It will create (by default) ovirt-engine-health-check.run in current
directory. Copy this one to the target machine and run it there.

Change-Id: Iafb49d107c3b2b5623d11d0c4bbf907d6398e987
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M Makefile
M ovirt-engine.spec.in
A packaging/setup/bin/bundle-ovirt-engine-health
A packaging/setup/bin/ovirt-engine-health
M packaging/setup/bin/ovirt-engine-setup
M packaging/setup/ovirt_engine_setup/constants.py
A packaging/setup/plugins/README
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/engine.py
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/versions.py
A packaging/setup/plugins/ovirt-engine-health/base/core/__init__.py
A packaging/setup/plugins/ovirt-engine-health/base/core/misc.py
12 files changed, 564 insertions(+), 3 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Yedidyah Bar David: Verified



-- 
To view, visit https://gerrit.ovirt.org/75372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafb49d107c3b2b5623d11d0c4bbf907d6398e987
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael at rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>