Change in ovirt-engine[ovirt-engine-4.1]: core: Fix permissions subtab of users
Code Review
gerrit at ovirt.org
Tue May 30 13:57:55 UTC 2017
>From Tal Nisan <tnisan at redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix permissions subtab of users
......................................................................
core: Fix permissions subtab of users
Previously the permissions sub-tab of user tab displayed permissions
of the user, which has assigned on specific object directly or
in-directly(inherited). But if the user was part of the group, those
permissions wasn't displayed. We displayed the permissions of the
groups of the currently logged-in user instead.
This patch fixes that, so we now display the permissions of the groups
of the user, which is selected in 'Users' tab instead of the user which
is currently logged-in.
Change-Id: Icbc1ee3b865349384b95a1d5f09880a448712359
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1455011
Signed-off-by: Ondra Machacek <omachace at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDaoImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java
M packaging/dbscripts/multi_level_administration_sp.sql
12 files changed, 164 insertions(+), 18 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbc1ee3b865349384b95a1d5f09880a448712359
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the Engine-commits
mailing list