[Engine-devel] Autorecovery feature plan for review

[Itamar Heim]

On 02/14/2012 09:48 AM, Omer Frenkel wrote:
>
>
> ----- Original Message -----
>> From: "Yair Zaslavsky"<yzaslavs at redhat.com>
>> To: engine-devel at ovirt.org
>> Sent: Tuesday, February 14, 2012 9:20:10 AM
>> Subject: Re: [Engine-devel] Autorecovery feature plan for review
>>
>> On 02/14/2012 08:59 AM, Itamar Heim wrote:
>>> On 02/14/2012 08:57 AM, Livnat Peer wrote:
>>>> On 14/02/12 05:56, Itamar Heim wrote:
>>>>> On 02/13/2012 12:32 PM, Laszlo Hornyak wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Please review the plan document for autorecovery.
>>>>>> http://www.ovirt.org/wiki/Features/Autorecovery
>>>>>
>>>>> why would we disable auto recovery by default? it sounds like the
>>>>> preferred behavior?
>>>>>
>>>>
>>>> I think that by default Laszlo meant in the upgrade process to
>>>> maintain
>>>> current behavior.
>>>>
>>>> I agree that for new entities the default should be true.
>>>
>>> i think the only combination which will allow this is for db to
>>> default
>>> to false and code to default to true for this property?
>> Why can't we during upgrade process set to all existing entities in
>> DB
>> the value to false, but still have the column defined as "default
>> true"?
>
> why all the trouble? i think this field should be mandatory as any other field,
> user has to specify it during the entity creation, right where he provide the name and any other field for the new entity.

because this will break the API?
what happens if user doesn't pass it, like they didn't so far?
i.e., you need to decide on a default.